updated action and added assignee #139433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ateklu7
requested review from
BearHanded,
braxex and
cassandradanger
as code owners
|
Code Climate has analyzed commit 378d372 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 55.6% (0.0% change). View more on Code Climate. |
BearHanded
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two workflow Jobs
Runs during PR creation on main and outputs the findings in GitHub Workflow console
Runs on Cron and creates JIRA ticket based on findings
Here is a sample JIRA output
https://qmacbis.atlassian.net/browse/MDCT-2579
JIRA ticket behavior
Exisitng ticket check is set to default 60days, this can be adjusted as needed.
The same Vulnerability can re-exist after the resoultion when a the same package is added for this reason there is acheck for Closed or Cancelled ticket and based on that a ticket get created.
SNYK Ignore
There is a .snyk file in the root directory that can hold a list of snyk ignore ids, a vulnerabiity can be manually added there following the same synaxt in the file, so when Snyk scan runs all the vulnerabilities in .snyk file will be ignored.
Related ticket(s)
How to test
Important updates
Author checklist
I have performed a self-review of my code
I have added thorough tests, if necessary
I have updated relevant documentation, if necessary